Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIP ROCTX: USE_RPATH Control #2064

Merged
merged 1 commit into from
Jun 1, 2021
Merged

HIP ROCTX: USE_RPATH Control #2064

merged 1 commit into from
Jun 1, 2021

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented May 27, 2021

Summary

Just rely on USE_RPATH instead for GNUmake. Follow-up to #2057

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@ax3l
HIP ROCTX: USE_RPATH Control
7397128 
Just rely on USE_RPATH instead for GNUmake.
Follow-up to #2057
@ax3l ax3l requested review from WeiqunZhang and jmsexton03 May 27, 2021 23:10
@ax3l
Copy link
Member Author

ax3l commented May 27, 2021

@WeiqunZhang upsi, I used the web interface 😅

@WeiqunZhang WeiqunZhang merged commit ecffb6a into development Jun 1, 2021
@WeiqunZhang WeiqunZhang deleted the cleanup-roctx branch June 1, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

@jmsexton03 jmsexton03 jmsexton03 approved these changes

Assignees

@WeiqunZhang WeiqunZhang

Labels
cleaning GPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ax3l @WeiqunZhang @jmsexton03