Fix bug in indexing for EB-inflow hyperbolics #895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pc_compute_hyp_mol_flux
, instead of definingspr
andspl
as new arrays that must be allocated and copied into, just point to the appropriate places inqtempl
andqtempr
. This cuts down on code and should be a bit more efficient.pc_compute_hyp_mol_flux_eb
do the same thing. Note that there is currently a bug where theqtemp
arrays aren't sized to store ADV/AUX/LIN quantities, but the indexing used assumes does account for these quantities. This fortunately seems to not have caused issues, but is now fixed.ProblemSpecificFunctions::problem_eb_state
we pass bothqtemp{l,r}
andsp{l,r}
as arguments. This is redundant, but shouldn't hurt anything as long as users understand this.@mjrahimi - can you verify that this updated version of the code works for the oxy-combustor case?