-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix (and merge) Dockerfiles, adds a CI job for building and uploading docker images #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gs-anssi
added a commit
that referenced
this pull request
Jan 10, 2025
* fix: glibc in final docker images * fix: pin rust image to major version based on debian * fix: adjust compose file for new Dockerfile * ci: public docker image on repo tag * ci: test pushing to own repo * ci: fix * ci: change image name * ci: fix image name again * ci: switch to upstream repo config * refactor: ARG for final base image * fix: switch to nonroot docker image
r3dlight
pushed a commit
that referenced
this pull request
Jan 10, 2025
* fix: glibc in final docker images * fix: pin rust image to major version based on debian * fix: adjust compose file for new Dockerfile * ci: public docker image on repo tag * ci: test pushing to own repo * ci: fix * ci: change image name * ci: fix image name again * ci: switch to upstream repo config * refactor: ARG for final base image * fix: switch to nonroot docker image
r3dlight
pushed a commit
that referenced
this pull request
Jan 10, 2025
* fix: glibc in final docker images * fix: pin rust image to major version based on debian * fix: adjust compose file for new Dockerfile * ci: public docker image on repo tag * ci: test pushing to own repo * ci: fix * ci: change image name * ci: fix image name again * ci: switch to upstream repo config * refactor: ARG for final base image * fix: switch to nonroot docker image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Hello 👋
This PR corrects an issue with the repository's Dockerfiles: the final images don't include the glibc dependency due to them using the slim variant of the debian image as the base.
The consequence of this is that the lidis/r binaries crash on startup when running the docker images built from this repository's Dockerfiles, moreover no docker image is published on the docker hub.
Note that it might be desirable to squash the commits when merging, the commit history is ok, but not ideal
✔️ Changelog
The PR addresses this by:
🥼 Tests
Note that I have tested the Github action logic for build, tagging and pushing the docker images but in my own fork (since I don't have access to this repo's CI). During my tests (which consisted of building and uploading the image's to my repo's github registry) everything worked as exepcted.