WIP: Allow AOM_HAVE_TUNE_IQ #2599
Conversation
|
wantehchang@, is that what you had in mind? The libaom bump is just for the tests |
| if (!lossless && !codec->internal->tuningSet) { | ||
| #if defined(AOM_HAVE_TUNE_IQ) | ||
| if (aomUsage == AOM_USAGE_ALL_INTRA && | ||
| aom_codec_control(&codec->internal->encoder, AOME_SET_TUNING, AOM_TUNE_IQ) != AOM_CODEC_OK) { |
There was a problem hiding this comment.
We are not ready to make AOM_HAVE_TUNE_IQ the default in libavif yet. But we can think about how to make the new tuning mode more discoverable.
For example, if we release libavif v1.2.0 after libaom v3.12.0 is released, we can mention the libaom codec-specific option tune=iq in the libavif v1.2.0 release notes.
|
Vincent: I removed the v1.2.0 milestone from this pull request. It should not require any change to libavif to use the new tune=iq codec-specific option in libaom v3.12.0. |
I've compiled latest git libaom-av1 + libavif and can confirm --codec aom --advanced tune=iq works (without changing the hardcoded limits for older aom versions).
The new tune should only be default for non-animated avif, otherwise there's an error " * aom_codec_set_option("tune", "iq") failed: Codec does not implement requested capability:" That's probably because tune=iq sets --deltaq-mode=6 which "can only be set in all intra mode". The exact command line with --advanced tune=iq works just fine with single-image input. |
|
Ok, let's wait for setting it by default then. |
No description provided.