Skip to content

fix(oma-pm): check `dpkg --configure` and `dpkg --triggers-only` exit…

Sign in for the full log view
GitHub Actions / clippy succeeded Feb 20, 2025 in 0s

clippy

2 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 2
Note 0
Help 0

Versions

  • rustc 1.84.1 (e71f9a9a9 2025-01-27)
  • cargo 1.84.1 (66221abde 2024-11-19)
  • clippy 0.1.84 (e71f9a9a98 2025-01-27)

Annotations

Check warning on line 1163 in oma-pm/src/apt.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
    --> oma-pm/src/apt.rs:1160:17
     |
1160 | /                 return Err(OmaAptError::DpkgFailedConfigure(io::Error::new(
1161 | |                     ErrorKind::Other,
1162 | |                     "Could not get dpkg exit status",
1163 | |                 )));
     | |___________________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
     |
1160 ~                 Err(OmaAptError::DpkgFailedConfigure(io::Error::new(
1161 +                     ErrorKind::Other,
1162 +                     "Could not get dpkg exit status",
1163 ~                 )))
     |

Check warning on line 1157 in oma-pm/src/apt.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
    --> oma-pm/src/apt.rs:1154:17
     |
1154 | /                 return Err(OmaAptError::DpkgFailedConfigure(io::Error::new(
1155 | |                     ErrorKind::Other,
1156 | |                     format!("dpkg return non-zero code: {}", x),
1157 | |                 )))
     | |___________________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
     = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
     |
1154 ~                 Err(OmaAptError::DpkgFailedConfigure(io::Error::new(
1155 +                     ErrorKind::Other,
1156 +                     format!("dpkg return non-zero code: {}", x),
1157 +                 )))
     |