-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form state update, index update #301
base: develop
Are you sure you want to change the base?
Form state update, index update #301
Conversation
@@ -29,7 +31,7 @@ export const CustomRadioButton: React.FC<CustomRadioButtonProps> = ({ | |||
id={`inline-radio-${index + 1}`} | |||
data-testid={`${dataTestid}-inline-radio-${index + 1}`} | |||
key={`radio-${index + 1}`} | |||
defaultChecked={index === 0} | |||
defaultChecked={index === indexValue} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onchange is common handler for selection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class name is empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is value prop in this radio btton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of passing indexValue do we need to pass the value to make sure default check. @arun-s-aot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree to that. index checking can be replaced with value checking @Bonymol-aot
Issue Tracking
JIRA:
Issue Type: BUG/ FEATURE
Changes