Form state update, index update #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arun-s-aot
approved these changes
Oct 17, 2024
shuhaib-aot
reviewed
Oct 21, 2024
| @@ -29,7 +31,7 @@ export const CustomRadioButton: React.FC<CustomRadioButtonProps> = ({ | |||
| id={`inline-radio-${index + 1}`} | |||
| data-testid={`${dataTestid}-inline-radio-${index + 1}`} | |||
| key={`radio-${index + 1}`} | |||
| defaultChecked={index === 0} | |||
| defaultChecked={index === indexValue} | |||
There was a problem hiding this comment.
onchange is common handler for selection
There was a problem hiding this comment.
where is value prop in this radio btton
There was a problem hiding this comment.
instead of passing indexValue do we need to pass the value to make sure default check. @arun-s-aot
There was a problem hiding this comment.
Agree to that. index checking can be replaced with value checking @Bonymol-aot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Tracking
JIRA:
Issue Type: BUG/ FEATURE
Changes