Skip to content

Commit

Permalink
Merge pull request #10 from ARCANEDEV/update-agent
Browse files Browse the repository at this point in the history
Updating the agent dependency
  • Loading branch information
arcanedev-maroc authored Feb 8, 2017
2 parents 99e291d + 8529e97 commit dc7652f
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 16 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"arcanedev/geo-ip": "~2.0",
"arcanedev/support": "~3.20",
"jaybizzle/crawler-detect": "~1.0",
"jenssegers/agent": "~2.0",
"arcanedev/agent": "~1.0",
"ramsey/uuid": "~3.0",
"snowplow/referer-parser": "~0.2",
"ua-parser/uap-php" : "~3.0"
Expand Down
7 changes: 4 additions & 3 deletions src/Detectors/DeviceDetector.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<?php namespace Arcanedev\LaravelTracker\Detectors;

use Arcanedev\Agent\Contracts\Agent;
use Arcanedev\LaravelTracker\Contracts\Detectors\DeviceDetector as DeviceDetectorContract;
use Arcanedev\LaravelTracker\Models\Device;

Expand All @@ -15,7 +16,7 @@ class DeviceDetector implements DeviceDetectorContract
| Properties
| ------------------------------------------------------------------------------------------------
*/
/** @var \Jenssegers\Agent\Agent */
/** @var \Arcanedev\Agent\Contracts\Agent */
protected $agent;

/* ------------------------------------------------------------------------------------------------
Expand All @@ -25,9 +26,9 @@ class DeviceDetector implements DeviceDetectorContract
/**
* DeviceDetector constructor.
*
* @param \Jenssegers\Agent\Agent $agent
* @param \Arcanedev\Agent\Contracts\Agent $agent
*/
public function __construct($agent)
public function __construct(Agent $agent)
{
$this->agent = $agent;
}
Expand Down
5 changes: 5 additions & 0 deletions src/Detectors/GeoIpDetector.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ class GeoIpDetector implements GeoIpDetectorContract
| Constructor
| ------------------------------------------------------------------------------------------------
*/
/**
* GeoIpDetector constructor.
*
* @param \Arcanedev\GeoIP\Contracts\GeoIP $geoip
*/
public function __construct(GeoIP $geoip)
{
$this->geoip = $geoip;
Expand Down
7 changes: 4 additions & 3 deletions src/Detectors/LanguageDetector.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<?php namespace Arcanedev\LaravelTracker\Detectors;

use Arcanedev\Agent\Contracts\Agent;
use Arcanedev\LaravelTracker\Contracts\Detectors\LanguageDetector as LanguageDetectorContract;

/**
Expand All @@ -14,7 +15,7 @@ class LanguageDetector implements LanguageDetectorContract
| Properties
| ------------------------------------------------------------------------------------------------
*/
/** @var \Jenssegers\Agent\Agent */
/** @var \Arcanedev\Agent\Contracts\Agent */
protected $agent;

/* ------------------------------------------------------------------------------------------------
Expand All @@ -24,9 +25,9 @@ class LanguageDetector implements LanguageDetectorContract
/**
* LanguageDetector constructor.
*
* @param \Jenssegers\Agent\Agent $agent
* @param \Arcanedev\Agent\Contracts\Agent $agent
*/
public function __construct($agent)
public function __construct(Agent $agent)
{
$this->agent = $agent;
}
Expand Down
10 changes: 2 additions & 8 deletions src/LaravelTrackerServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -115,15 +115,9 @@ private function registerDetectors()
return new Detectors\CrawlerDetector($crawler);
});

$this->singleton(Contracts\Detectors\DeviceDetector::class, function (AppContract $app) {
return new Detectors\DeviceDetector($app['agent']);
});

$this->singleton(Contracts\Detectors\DeviceDetector::class, Detectors\DeviceDetector::class);
$this->singleton(Contracts\Detectors\GeoIpDetector::class, Detectors\GeoIpDetector::class);

$this->singleton(Contracts\Detectors\LanguageDetector::class, function (AppContract $app) {
return new Detectors\LanguageDetector($app['agent']);
});
$this->singleton(Contracts\Detectors\LanguageDetector::class, Detectors\LanguageDetector::class);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/Providers/PackagesServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public function register()
{
$this->registerProviders([
\Arcanedev\GeoIP\GeoIPServiceProvider::class,
\Jenssegers\Agent\AgentServiceProvider::class,
\Arcanedev\Agent\AgentServiceProvider::class,
]);
}
}

0 comments on commit dc7652f

Please sign in to comment.