Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cortex(M): align core header with TRMs #56

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Cortex(M): align core header with TRMs #56

merged 2 commits into from
Oct 31, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 16, 2023

Reworked CMSIS core header files:

  • align with latest TRMs
  • unified core header

@ghost ghost requested review from RobertRostohar and JonatanAntoni October 16, 2023 12:35
@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

Test Results

   168 files   -    168     168 suites   - 168   0s ⏱️ - 6m 32s
     56 tests +       7       54 ✔️ +     10         2 💤  -        3  0 ❌ ±0 
8 964 runs   - 7 500  6 948 ✔️  - 3 684  2 016 💤  - 3 816  0 ❌ ±0 

Results for commit 180a4e7. ± Comparison against base commit 29ed1bc.

This pull request removes 49 and adds 56 tests. Note that renamed tests count towards both. 
CMSIS-Core.CMSIS-Core ‑ apsr.c
CMSIS-Core.CMSIS-Core ‑ basepri.c
CMSIS-Core.CMSIS-Core ‑ bkpt.c
CMSIS-Core.CMSIS-Core ‑ clrex.c
CMSIS-Core.CMSIS-Core ‑ clz.c
CMSIS-Core.CMSIS-Core ‑ control.c
CMSIS-Core.CMSIS-Core ‑ cp15.c
CMSIS-Core.CMSIS-Core ‑ cpsr.c
CMSIS-Core.CMSIS-Core ‑ dmb.c
CMSIS-Core.CMSIS-Core ‑ dsb.c
…

TC_CML1Cache_CleanDCacheByAddrWhileDisabled
TC_CML1Cache_EnDisableDCache
TC_CML1Cache_EnDisableICache
TC_CoreFunc_APSR
TC_CoreFunc_BASEPRI
TC_CoreFunc_Control
TC_CoreFunc_EnDisIRQ
TC_CoreFunc_EncDecIRQPrio
TC_CoreFunc_FAULTMASK
TC_CoreFunc_FPSCR
…
This pull request removes 5 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both. 
CMSIS-Core.CMSIS-Core ‑ lda.c
CMSIS-Core.CMSIS-Core ‑ ldaex.c
CMSIS-Core.CMSIS-Core ‑ stl.c
CMSIS-Core.CMSIS-Core ‑ stlex.c
CMSIS-Core.CMSIS-Core ‑ systick.c

TC_CoreInstr_WFE
TC_CoreInstr_WFI

♻️ This comment has been updated with latest results.

RobertRostohar
RobertRostohar reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@RobertRostohar RobertRostohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (see one inline comment).

CMSIS/RTOS2/Source/os_systick.c Show resolved Hide resolved
@ghost ghost force-pushed the v8-M_TRM branch from 1e393cc to 0581af8 Compare October 17, 2023 06:25
@JonatanAntoni JonatanAntoni mentioned this pull request Oct 17, 2023
Open
JonatanAntoni
JonatanAntoni requested changes Oct 17, 2023
View reviewed changes
ARM.CMSIS.pdsc Outdated Show resolved Hide resolved
ARM.CMSIS.pdsc Outdated Show resolved Hide resolved
ARM.CMSIS.pdsc Show resolved Hide resolved
ARM.CMSIS.pdsc Outdated Show resolved Hide resolved
ARM.CMSIS.pdsc Outdated Show resolved Hide resolved
CMSIS/Core/Include/cmsis_version.h Outdated Show resolved Hide resolved
CMSIS/Core/Include/core_ca.h Show resolved Hide resolved
@JonatanAntoni JonatanAntoni self-requested a review October 17, 2023 10:16
JonatanAntoni
JonatanAntoni previously approved these changes Oct 17, 2023
View reviewed changes
@JonatanAntoni
Copy link
Member

@GuentherMartin, could you please rebase once again?

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 30, 2023
View reviewed changes
CMSIS/Core/Include/core_ca.h Fixed Show resolved Hide resolved
ghost
ghost commented Oct 31, 2023
View reviewed changes
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@JonatanAntoni JonatanAntoni merged commit 5720958 into main Oct 31, 2023
8 checks passed
@JonatanAntoni JonatanAntoni deleted the v8-M_TRM branch October 31, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonatanAntoni @RobertRostohar