Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Unify __NO_INIT macro across toolchains #89

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Core: Unify __NO_INIT macro across toolchains #89

merged 2 commits into from
Nov 23, 2023

Conversation

MiloradCvjetkovic
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Nov 23, 2023

Test Results

0 files   -      336  0 suites   - 336   0s ⏱️ - 7m 50s
0 tests  -        49  0 ✔️  -        44  0 💤  -        5  0 ±0 
0 runs   - 16 464  0 ✔️  - 10 632  0 💤  - 5 832  0 ±0 

Results for commit f1dcf0d. ± Comparison against base commit e32b987.

♻️ This comment has been updated with latest results.

@JonatanAntoni
Copy link
Member

This needs to be aligned with the linker scripts. It is going to break existing implementations based on the new macro.

https://github.com/Open-CMSIS-Pack/devtools/tree/main/tools/projmgr/templates

@MiloradCvjetkovic
Copy link
Contributor Author

It only impacts ac6_linker_script.sct and it could be made that both .bss.noinit and .noinit are supported.
Actually, it would be best that supported are .bss.noinit* and ,noinit*, as for example Fault component uses section name .noinit.fault .
BTW, gcc_linker_script.ld and clang_linker_script.ld do not contain provisions for the .noinit section at all.

@ghost
Copy link

ghost commented Nov 23, 2023

Provisions for .noinit should be added to gcc_linker_script.ld and clang_linker_script.ld if they are not already contained .

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are linker scripts which need to be updated part of this PR?

@JonatanAntoni JonatanAntoni merged commit 7002cdf into ARM-software:main Nov 23, 2023
8 checks passed
@MiloradCvjetkovic MiloradCvjetkovic deleted the Unify_noinit branch November 28, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants