Minor modification to FMV rules for scope and signatures

[AlfieRichardsArm]

Hi all,

While attempting to implement FMV in the GCC front-end some questions were raised that I think are worth clarifying here.

This PR changes the rules to use the default function to determine the signature and scope of the versioned function set.

This clears up some cases such as:

int fn (int c = 1);
int __attribute__((target_version("sve"))) fn (int c = 2);

int bar() { return fn(); }

Where there are conflicting signatures and which default should be used is not clear at the moment.

int fn (int c[]);
int __attribute__((target_version("default"))) fn (int c[1]) {
}
int __attribute__((target_version("sve"))) fn (int c[2]) {
}

Where if this should be considered a conflicting signature is not clear.

int __attribute__((target_version("default"))) fn (int x) {
    return 1;
}

void bar () {
    int __attribute__((target_version("sve2"))) fn (int);
    fn(1);
}

Where the scope of multi-versioned functions differs.

And

// TU 1
#import TU2

int fn (int c = 1);

int bar() { return fn(); }

// TU 2

int __attribute__((target_version("sve"))) fn (int c = 2);
int __attribute__((target_version("sve2"))) fn (int c = 2);

int bar() { return fn(); }

Where it is possible calls in different TU's could use different default argument values.

---

name: Pull request
about: Technical issues, document format problems, bugs in scripts or feature proposal.

---

Thank you for submitting a pull request!

If this PR is about a bugfix:

Please use the bugfix label and make sure to go through the checklist below.

If this PR is about a proposal:

We are looking forward to evaluate your proposal, and if possible to
make it part of the Arm C Language Extension (ACLE) specifications.

We would like to encourage you reading through the contribution
guidelines, in particular the section on submitting
a proposal.

Please use the proposal label.

As for any pull request, please make sure to go through the below
checklist.

Checklist: (mark with X those which apply)

• If an issue reporting the bug exists, I have mentioned it in the
  PR (do not bother creating the issue if all you want to do is
  fixing the bug yourself).
• I have added/updated the SPDX-FileCopyrightText lines on top
  of any file I have edited. Format is SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}>
  (Please update existing copyright lines if applicable. You can
  specify year ranges with hyphen , as in 2017-2019, and use
  commas to separate gaps, as in 2018-2020, 2022).
• I have updated the Copyright section of the sources of the
  specification I have edited (this will show up in the text
  rendered in the PDF and other output format supported). The
  format is the same described in the previous item.
• I have run the CI scripts (if applicable, as they might be
  tricky to set up on non-*nix machines). The sequence can be
  found in the contribution
  guidelines. Don't
  worry if you cannot run these scripts on your machine, your
  patch will be automatically checked in the Actions of the pull
  request.
• I have added an item that describes the changes I have
  introduced in this PR in the section Changes for next
  release of the section Change Control/Document history
  of the document. Create Changes for next release if it does
  not exist. Notice that changes that are not modifying the
  content and rendering of the specifications (both HTML and PDF)
  do not need to be listed.
• When modifying content and/or its rendering, I have checked the
  correctness of the result in the PDF output (please refer to the
  instructions on how to build the PDFs
  locally).
• The variable draftversion is set to true in the YAML header
  of the sources of the specifications I have modified.
• Please DO NOT add my GitHub profile to the list of contributors
  in the README page of the project.

[AlfieRichardsArm]

I have updated this PR with (hopefully) clearer wording more inline with @labrinea 's suggestions.

[AlfieRichardsArm]

I have changed the rule for whats allowed signature wise after a suggestion by @rsandifo-arm which makes it more precise in terms of function types and added some examples.

Specifically, the rule change specifies compatibility in terms of if the types are compatible, and the example shows this in terms of function pointers.
The argument there being that behind the scenes FMV is the load time initialization of a function pointer, so it makes sense to consider compatibility in terms of function pointer compatibility.

[vhscampos]

If no objections are raised, let's merge this on the 23 December.

[AlfieRichardsArm]

@labrinea Thank you for the feedback, I addressed them and in doing so moved some stuff around slightly so I hope it makes more sense now.

[labrinea]

May we move the sentence https://github.com/ARM-software/acle/blob/main/main/acle.md?plain=1#L2695 here https://github.com/ARM-software/acle/blob/main/main/acle.md?plain=1#L2677 and rephase it as "Functions are allowed to have the same name when annotated with these attributes." Then in https://github.com/ARM-software/acle/blob/main/main/acle.md?plain=1#L2695 we could say "when applied to a function it becomes one of the versions. Multiple function versions may exist in the same or in different translation units."

Now regarding the order of bullet points I think it could be improved to help the reader. For example the second bullet point refers to the default version a bit suddenly. The third bullet point refers to the table of features which mentions 'default' for the first time in this document.

Also some of thebullet points refer to FMV semantics whereas others specifically refer to the FMV attributes. Perhaps it's worth separating those.

This can be done in a separate commit.

[AlfieRichardsArm]

I agree the bullets can be made clearer. I will look into making another PR for that work shortly.

I addressed your feedback and while reading through made a few other touches to parts hopefully within scope for this change to make it a little clearer.