Add JetNews to the available workloads #1240
Conversation
The jetnews wa workload runs a single test at the moment, but there are more tests available. This patch enables two additional basic tests and renames the wa workload name to "jetnews", in preparation to potential future updates where we will be able to select the kind of test we want to run.
wa/workloads/jetnews/__init__.py:18:1: E302 expected 2 blank lines, found 1
- Formatting fixes - Use of proper type of workload (ApkWorkload) - Use f-strings - Add parameters for the workload (tests and iterations)
The unused variable is only used to iteration through the test as many times as specified.
- wa/workloads/jetnews/__init__.py:67:31: E211 whitespace before '('
- wa/workloads/jetnews/__init__.py:67:50: E261 at least two spaces before inline comment
|
Addressed the comments in this updated PR. I plan to submit the documentation bits separately. Honestly, I don't think the workloads is yet at a stage where we can just use it. It needs a bit more work. |
|
ping? |
Thanks for fixing these, it looks like the changes are heading in the right direction.
No problem please reach out if you have any questions and I can try to answer or point you to the relevant parts of the documentation that might help.
Makes sense, on my side I was able to execute the workload and it launched the Jetnews application, however it doesn't currently seem to perform any tests. There are also no test metrics collected from the workload that would allow for comparison between runs. Are these the sort of extra work that you have planned for this workload? |
Yes, exactly. This initial contribution is a base from which we should (hopefully) build something more meaningful. So things like improved/more meaningful tests, collecting metrics etc, will come later. I don't think we want dependencies on perfetto, so I still need to check how that is going to work in terms of data collection. We'll probably do ftrace, but we need the jank information. Right now there are 3 very basic tests that scroll things, and you can select those and pass the number of iterations. Even those tests don't seem to work 100% at the moment. |
|
Ok cool thanks for confirming. In which case happy to leave this here as a base that can be used for further development. |
|
I have a different patch to enable this. |
These three commits add the JetNews workload to the main branch of wa. The first two commits were contributed by Jakub Szostakowski. The third commit is where I picked things up to start making it useful for our team's needs. And also to keep these workloads in a central repo/branch so they don't get scattered around multiple teams/repos.