speed shepardSearchNeighbour

ARPA-SIMC · Jan 10, 2025 · bd24120 · bd24120
1 parent d1f7e14
commit bd24120
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 23 deletions.
diff --git a/interpolation/interpolation.cpp b/interpolation/interpolation.cpp
@@ -850,27 +850,23 @@ float shepardSearchNeighbour(vector <Crit3DInterpolationDataPoint> &inputPoints,
                              Crit3DInterpolationSettings* settings,
                              vector <Crit3DInterpolationDataPoint> &outputPoints)
 {
-    std::vector <Crit3DInterpolationDataPoint> shepardNeighbourPoints;
-
-    float radius;
-    unsigned int nrValid = 0;
     float shepardInitialRadius = computeShepardInitialRadius(settings->getPointsBoundingBoxArea(),
                                                              unsigned(inputPoints.size()), SHEPARD_AVG_NRPOINTS);
 
     // define a first neighborhood inside initial radius
+    std::vector <Crit3DInterpolationDataPoint> shepardNeighbourPoints;
     for (unsigned int i=0; i < inputPoints.size(); i++)
     {
         if (inputPoints[i].distance <= shepardInitialRadius &&
             inputPoints[i].distance > 0 &&
             inputPoints[i].index != settings->getIndexPointCV())
         {
             shepardNeighbourPoints.push_back(inputPoints[i]);
-            nrValid++;
         }
     }
 
     // If the points are too few, double the check radius
-    if (shepardNeighbourPoints.size() <= SHEPARD_MIN_NRPOINTS)
+    if (shepardNeighbourPoints.size() < SHEPARD_MIN_NRPOINTS)
     {
         float doubleRadius = shepardInitialRadius * 2;
         for (unsigned int i=0; i < inputPoints.size(); i++)
@@ -880,29 +876,21 @@ float shepardSearchNeighbour(vector <Crit3DInterpolationDataPoint> &inputPoints,
                 inputPoints[i].index != settings->getIndexPointCV())
             {
                 shepardNeighbourPoints.push_back(inputPoints[i]);
-                nrValid++;
             }
         }
+        shepardInitialRadius = doubleRadius;
     }
 
-    if (shepardNeighbourPoints.size() <= SHEPARD_MIN_NRPOINTS)
+    float radius;
+    if (shepardNeighbourPoints.size() < SHEPARD_MIN_NRPOINTS)
     {
-        nrValid = sortPointsByDistance(SHEPARD_MIN_NRPOINTS + 1, inputPoints, outputPoints);
-        if (nrValid > SHEPARD_MIN_NRPOINTS)
-        {
-            radius = outputPoints[SHEPARD_MIN_NRPOINTS].distance;
-            outputPoints.pop_back();
-        }
-        else
-        {
-            radius = outputPoints[nrValid-1].distance + float(EPSILON);
-        }
+        int nrPoints = sortPointsByDistance(SHEPARD_MIN_NRPOINTS, inputPoints, outputPoints);
+        radius = outputPoints[nrPoints-1].distance + float(EPSILON);
     }
     else if (shepardNeighbourPoints.size() > SHEPARD_MAX_NRPOINTS)
     {
-        nrValid = sortPointsByDistance(SHEPARD_MAX_NRPOINTS + 1, shepardNeighbourPoints, outputPoints);
-        radius = outputPoints[SHEPARD_MAX_NRPOINTS].distance;
-        outputPoints.pop_back();
+        int nrPoints = sortPointsByDistance(SHEPARD_MAX_NRPOINTS, shepardNeighbourPoints, outputPoints);
+        radius = outputPoints[nrPoints-1].distance + float(EPSILON);
     }
     else
     {

diff --git a/interpolation/interpolationConstants.h b/interpolation/interpolationConstants.h
@@ -3,8 +3,8 @@
 
     #define MIN_REGRESSION_POINTS 5
     #define PEARSONSTANDARDTHRESHOLD 0.1
-    #define SHEPARD_MIN_NRPOINTS 4
-    #define SHEPARD_AVG_NRPOINTS 7
+    #define SHEPARD_MIN_NRPOINTS 5
+    #define SHEPARD_AVG_NRPOINTS 8
     #define SHEPARD_MAX_NRPOINTS 10
 
     #ifndef _STRING_