initial problem generator module #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s5bug
approved these changes
Feb 5, 2025
src/lib/ProblemGenerator.ts
Outdated
Comment on lines
24
to
29
| let num = this.generateNumber(digits, true); | ||
| result.push(num); | ||
|
|
||
| if (result.reduce((sum, n) => sum + n, 0) <= 0) { | ||
| result.pop(); | ||
| } |
There was a problem hiding this comment.
I would suggest instead replacing all these checks by
- Keeping a running sum separate to
result - Passing
-theRunningSumtogenerateNumberas something likefurthestNegativeAllowed - Rejecting negation if the number it generates is less than
furthestNegativeAllowed
There was a problem hiding this comment.
I.e., keeping this method O(n) rather than unbounded if you get mega unlucky.
There was a problem hiding this comment.
let me know if you see any issues with the updated one.
src/lib/ProblemGenerator.ts
Outdated
| return [num1, num2]; | ||
| } | ||
|
|
||
| divide(digits1: number, digits2: number): number[] { |
There was a problem hiding this comment.
Perhaps the result of this, rather than number[], should be some sort of ProblemSet class with an entries: number[] field and a result: number field.
s5bug
approved these changes
Feb 5, 2025
added class ProblemSet
JacksonWKennedy
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.