created flashing number + status of flash + result checker #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATOMiNATiON
requested changes
Feb 11, 2025
Pfefferpotthast
previously approved these changes
Feb 11, 2025
* Fixed only numbers flashing on screen * Submission button created for users to click * Validation shows up only after users submits answers * Changed *Done* to *Answer*
- Changed placeholder to let user know what to input - Updated the # of numbers to flash to have 15 - Fixed speed min value to be 0.2, so it's doable
s5bug
reviewed
Feb 12, 2025
| height: 100vh; | ||
| margin: 0; | ||
| font-family: Arial, sans-serif; | ||
| background-image: url('/mathArenaBkg.jpg'); |
There was a problem hiding this comment.
I need to make a PR down the line moving all this stuff into a common stylesheet. Out of scope for this PR
s5bug
requested changes
Feb 12, 2025
JacksonWKennedy
approved these changes
Feb 12, 2025
Pfefferpotthast
approved these changes
Feb 12, 2025
- Resolve nitpick "a number" on all the field input - Resolve nitpick "sec" for speed
ATOMiNATiON
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shows if it's currently flashing or not and if it's done it'll show, and added the back button to go back to the prev and restart it, and it has a box where you can put in the answer and it'll alert if its right or wrong