Previous Problem, Hide and Show Practice Problem Answer #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s5bug
requested changes
Feb 14, 2025
| const toggleResultButton = document.getElementById('toggleResultButton'); | ||
|
|
||
| if (problemEntriesDiv && correctResultDiv) { | ||
| problemEntriesDiv.innerHTML = `${problemEntries.map((entry: any) => `(${entry})`).join(' + ')}`; |
There was a problem hiding this comment.
This should be done using a component rather than constructing innerHTML. You can create a new component (perhaps PreviousProblemDisplay) that accepts an array as a property and has the content of
<div>
{entries.flatMap(e => [' + ', e]).slice(1)}
</div>
Pfefferpotthast
force-pushed
the
previous
branch
from
58534ff to
7dba563
Compare
s5bug
approved these changes
Feb 15, 2025
ATOMiNATiON
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.