extra_only / main_ui_only ScriptPostprocessing; fix Simple Upscale #16374
+15
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add extra_only and main_ui_only attr to ScriptPostprocessing a script with extra_only = True can only run on extra and not be used in main UI, vice versa shared_items.postprocessing_scripts now have filter_out_main_ui_only and filter_out_extra_only args
w-e-w
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix
Simple Upscalementioned by @light-and-ray in Discord for whatever reason the the main UI only script
Simple Upscalewas hidden and not selectablemy guess is doing some refactoring some logical change and so it got lost
this PR as it back by changing how a ScriptPostprocessing
is filtered out by adding 2 new attribute toScriptPostprocessing,ScriptPostprocessing.extra_onlyandScriptPostprocessing.main_ui_onlywhen set toTure`, the script will only show ther specified tabexample
Simple Upscalenow has the.main_ui_onlyset to trueand so will only work in main ui if added into
opts.postprocessing_enable_in_main_uishared_items.postprocessing_scripts(filter_out_extra_only=False, filter_out_main_ui_only=False)now have filter options to filter out the two script typesthe advantage of doing this way as opposed to adding a special case for
Simple Upscaleis that extensions if they so wish to can limit their use on specific tabsScreenshots/videos:
Checklist: