Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update delete feature according to feedback from PR #103

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Update delete feature according to feedback from PR #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8038046
Updated
yyyaohhh Oct 17, 2023
3400a26
Update according to feedback from PR
yyyaohhh Oct 17, 2023
dba6157
Merge branch 'Delete-Feature' of https://github.com/yyyaohhh/tp into …
yyyaohhh Oct 17, 2023
40aa6bc
Bug Fix for Delete
yyyaohhh Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/seedu/address/logic/commands/DeleteCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
import seedu.address.model.module.Module;
import seedu.address.model.module.ModuleCode;


/**
* Deletes a person identified using it's displayed index from the address book.
*/
Expand All @@ -24,7 +23,7 @@ public class DeleteCommand extends Command {
+ "Example: " + COMMAND_WORD + " " + PREFIX_CODE + "CS2103T ";

public static final String MESSAGE_DELETE_MODULE_SUCCESS = "Deleted Module: %1$s";
public static final String MESSAGE_NOT_FOUND_MODULE = "This module is not found and has not been added.";
public static final String MESSAGE_NOT_FOUND_MODULE = "This module is not found and has not been deleted.";

private final ModuleCode toDelete;

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/seedu/address/logic/parser/DeleteCommandParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class DeleteCommandParser implements Parser<DeleteCommand> {
*/
public DeleteCommand parse(String args) throws ParseException {
try {
ModuleCode code = ParserUtil.parseCode(args);
ModuleCode code = ParserUtil.parseModuleCode(args);
return new DeleteCommand(code);

} catch (ParseException pe) {
Expand Down
Loading