Create ModulePlan and Refactor #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyyaohhh
reviewed
Oct 18, 2023
| Module editedCS2040S = new ModuleBuilder() | ||
| .withCode("CS2040S") | ||
| .withYear("1") | ||
| .withSem("1") |
There was a problem hiding this comment.
The semester input here does not correspond to the format after changing
yyyaohhh
reviewed
Oct 18, 2023
| @@ -105,7 +105,7 @@ public Module find(ModuleCode code) { | |||
| return mods[i]; | |||
| } | |||
| } | |||
| throw new ModuleNotFoundException(); | |||
| return null; | |||
There was a problem hiding this comment.
JavaDocs at line 98 can be removed accordingly
|
LGTM👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#106
Tests for EditCommand and FindCommand still require refactoring to ModulePlan.
Storage for ModulePlan not yet implemented.