Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests #233

Merged
merged 14 commits into from
Nov 12, 2023
Merged

Conversation

marquestye
Copy link

@marquestye marquestye commented Nov 12, 2023

Added tests for Module and its fields.
Added tests to UserPrefs and ModuleData.
Removed depreciated methods in ModuleData.

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd8946c) 74.30% compared to head (0fb0321) 76.59%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #233      +/-   ##
============================================
+ Coverage     74.30%   76.59%   +2.29%     
- Complexity      525      554      +29     
============================================
  Files            78       78              
  Lines          1755     1752       -3     
  Branches        178      178              
============================================
+ Hits           1304     1342      +38     
+ Misses          379      354      -25     
+ Partials         72       56      -16     
Files Coverage Δ
src/main/java/seedu/address/model/ModuleData.java 94.44% <ø> (+9.82%) ⬆️
...n/java/seedu/address/model/module/Description.java 100.00% <ø> (+21.42%) ⬆️
...java/seedu/address/model/module/ModularCredit.java 100.00% <100.00%> (+26.66%) ⬆️
...in/java/seedu/address/model/module/ModuleName.java 100.00% <ø> (+21.42%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marquestye marquestye marked this pull request as ready for review November 12, 2023 09:11
@rocketninja7
Copy link

LGTM 👍

@rocketninja7 rocketninja7 merged commit 73c9e67 into AY2324S1-CS2103T-T13-0:master Nov 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants