Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UG for info, calculateCAP, calculateMC #243

Merged
merged 16 commits into from
Nov 13, 2023

Conversation

ji-just-ji
Copy link

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ba1608) 81.67% compared to head (593cfd9) 81.67%.
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #243   +/-   ##
=========================================
  Coverage     81.67%   81.67%           
  Complexity      593      593           
=========================================
  Files            78       78           
  Lines          1746     1746           
  Branches        174      174           
=========================================
  Hits           1426     1426           
  Misses          294      294           
  Partials         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ji-just-ji ji-just-ji changed the title UG update for info, calculateCAP, calculateMC Update UG for info, calculateCAP, calculateMC Nov 13, 2023
Comment on lines 318 to 319
* info CS2109S
* info CS1010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should include explanation for each example command.

if () then ([else])
:ParseException: Invalid Command Format;
stop
( [all fields are filled and valid] ) elseif() then ([else]))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra )

Comment on lines 15 to 16
:ParseException: Invalid Command Format;
stop

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can try adding puml partitions (AddCommandParser and AddCommand) to show where everything happens.

docs/diagrams/AddModuleActivityDiagram.puml Show resolved Hide resolved
@rocketninja7 rocketninja7 added this to the v1.4 milestone Nov 13, 2023
Copy link

@xCOLOURx xCOLOURx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@xCOLOURx xCOLOURx merged commit 43db91a into AY2324S1-CS2103T-T13-0:master Nov 13, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants