Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Module class with preliminary testing #79

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

rocketninja7
Copy link

No description provided.

Copy link

@ji-just-ji ji-just-ji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecturer -> List
Null/W grade option
Year to 0-6

Let's:
* allow a single module to have multiple Lecturer
* add more non conventional kinds of Grade
* change format of Year
* update JavaDocs
@rocketninja7
Copy link
Author

Lecturer -> List Null/W grade option Year to 0-6

Thanks for the feedback! Just updated the PR with a commit to fix those issues!

@codecov-commenter
Copy link

Codecov Report

Attention: 115 lines in your changes are missing coverage. Please review.

Comparison is base (0dd42c1) 75.26% compared to head (692fe98) 70.36%.
Report is 19 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #79      +/-   ##
============================================
- Coverage     75.26%   70.36%   -4.90%     
- Complexity      419      428       +9     
============================================
  Files            71       79       +8     
  Lines          1338     1505     +167     
  Branches        126      137      +11     
============================================
+ Hits           1007     1059      +52     
- Misses          301      416     +115     
  Partials         30       30              
Files Coverage Δ
...rc/main/java/seedu/address/model/module/Grade.java 74.41% <74.41%> (ø)
...in/java/seedu/address/model/module/ModuleCode.java 21.42% <21.42%> (ø)
...main/java/seedu/address/model/module/Semester.java 57.69% <57.69%> (ø)
...n/java/seedu/address/model/module/Description.java 0.00% <0.00%> (ø)
...main/java/seedu/address/model/module/Lecturer.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/model/module/Name.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/model/module/Year.java 0.00% <0.00%> (ø)
...c/main/java/seedu/address/model/module/Module.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ji-just-ji ji-just-ji merged commit 3738f06 into AY2324S1-CS2103T-T13-0:master Oct 10, 2023
3 checks passed
@rocketninja7
Copy link
Author

#67

@rocketninja7 rocketninja7 added this to the v1.2 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants