Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UniqueModuleList and necessary Exceptions #83

Merged

Conversation

ji-just-ji
Copy link

These are also needed for adding new modules, potentially needed for deleting modules.

@codecov-commenter
Copy link

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (3738f06) 70.36% compared to head (98fcef4) 68.14%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #83      +/-   ##
============================================
- Coverage     70.36%   68.14%   -2.22%     
  Complexity      428      428              
============================================
  Files            79       82       +3     
  Lines          1505     1554      +49     
  Branches        137      145       +8     
============================================
  Hits           1059     1059              
- Misses          416      465      +49     
  Partials         30       30              
Files Coverage Δ
...del/module/exceptions/ModuleNotFoundException.java 0.00% <0.00%> (ø)
...el/module/exceptions/DuplicateModuleException.java 0.00% <0.00%> (ø)
...a/seedu/address/model/module/UniqueModuleList.java 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rocketninja7
Copy link

LGTM

@rocketninja7 rocketninja7 merged commit 59cbc26 into AY2324S1-CS2103T-T13-0:master Oct 11, 2023
3 checks passed
@rocketninja7
Copy link

Fixes #67

@rocketninja7 rocketninja7 added this to the v1.2 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants