Complete tP AB3 Tutorial #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tutorial consists of making changes to the existing codebase by adding a Remark feature and removing the Address field. with respect to our tP, both changes are likely to be kept as they are relevant. Let's, * Implement Remark feature and update all dependent code components. * Update JSON data and add tests for Remark feature. * Remove Address class and all instances of Address. * Update JSON data and remove all tests including Address field.
Current code iteration violates various checkstyle guidelines and fails Continuous Integration checks. Let's, * Review checkstyle errors and correct them.
Resolve a few more violations that went unnoticed in previous commit.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4 +/- ##
============================================
- Coverage 75.26% 74.77% -0.49%
- Complexity 419 429 +10
============================================
Files 71 73 +2
Lines 1338 1348 +10
Branches 126 129 +3
============================================
+ Hits 1007 1008 +1
- Misses 301 309 +8
- Partials 30 31 +1 ☔ View full report in Codecov by Sentry. |
gingerbreaf
closed this pull request by merging all changes
into
AY2324S2-CS2103T-F11-3:master
in
1354b1f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tutorial consists of making changes to the existing codebase by adding a Remark feature and removing the Address field.
with respect to our tP, both changes are likely to be kept as they are relevant.
Let's,