Add Applicant type #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fit the requirements of out tP idea, just having a Person class is insufficient. There needs to be a more specific class for differentiation with other Person types to be implemented in the future. Let's, * Add an Applicant class. * Add the corresponding Command and CommandParser classes. * Update related test cases.
…into add-applicant-type
This was
linked to
issues
Mar 10, 2024
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #46 +/- ##
============================================
+ Coverage 74.77% 74.81% +0.03%
- Complexity 429 432 +3
============================================
Files 73 75 +2
Lines 1348 1354 +6
Branches 129 129
============================================
+ Hits 1008 1013 +5
- Misses 309 310 +1
Partials 31 31 ☔ View full report in Codecov by Sentry. |
headcube1
approved these changes
Mar 16, 2024
| */ | ||
| public class AddApplicantCommand extends AddCommand { | ||
|
|
||
| public static final String COMMAND_WORD = AddCommand.COMMAND_WORD + "_applicant"; |
There was a problem hiding this comment.
Looks good! Nice way of creating a new class that inherits from the AddCommand.
| */ | ||
| public class AddCommand extends Command { | ||
| public abstract class AddCommand extends Command { | ||
|
|
||
| public static final String COMMAND_WORD = "add"; | ||
|
|
There was a problem hiding this comment.
Changing to abstract class. Will take note!
| * Guarantees: details are present and not null, field values are validated, immutable. | ||
| */ | ||
| public class Applicant extends Person { | ||
|
|
There was a problem hiding this comment.
Nice use of inheritance to create a subclass of Persons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.