infoblox paging #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skalpin
requested review from
k0da,
kuritka,
ampie,
januarios,
Buzzglo and
TebogoTS
as code owners
|
Awesome @skalpin ! 🚀 Thanks for PR. Please, can you inject apache2 license by calling Thank you. |
kuritka
reviewed
Jun 4, 2024
|
@skalpin pls squash commits and we're good to go |
|
You can amend commit name with feat: Infoblox paging support, if you want 1.0.1 to be released straight |
|
@k0da , it looks like I need a second approver. Is there another owner I should reach out to specifically? |
|
@skalpin I'll approve once you'll squash commits |
|
I misunderstood. Squashed. |
k0da
approved these changes
Jun 5, 2024
|
@skalpin can you also sign your commit pls |
|
Hi @skalpin, please, can you also sign your commit ? I'm sorry, contribution manual is comming: https://github.com/AbsaOSS/external-dns-infoblox-webhook/pull/8/files . |
|
@k0da no problem. Should be verified now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.