Fix Windows Static Build #1897
Merged
Fix Windows Static Build #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Bailey <[email protected]>
danrbailey
requested review from
kmuseth,
apradhana,
jmlait,
Idclip and
richhones
as code owners
apradhana
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Thanks for finding out what's wrong with Windows static build @danrbailey! I was able to narrow it down to a problem in FindBlosc.cmake and you found the problem. This looks good.
danrbailey
merged commit 8ea30d5
into
AcademySoftwareFoundation:master
41 of 46 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier versions of Blosc required explicit library prefix/suffix modification. With more recent versions, this is no longer required and resolves a long-standing issue on Windows static builds where a "lib" prefix was being incorrectly applied and failing to find Blosc dependencies like LZ4 as a result. This change was informed by the patches being applied by package maintainers to build OpenVDB static libraries.