Merge pull request #549 from AcclaroInc/release/3.4.3

Release v3.4.3
AcclaroInc · Jan 13, 2025 · e991284 · e991284
2 parents 03d4470 + fddf33a
commit e991284
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/.craftplugin b/.craftplugin
@@ -1,7 +1,7 @@
 {
     "pluginName": "Translations for Craft",
     "pluginDescription": "Drive global growth with simplified translation workflows.",
-    "pluginVersion": "3.4.2",
+    "pluginVersion": "3.4.3",
     "pluginAuthorName": "Acclaro",
     "pluginVendorName": "Acclaro",
     "pluginAuthorUrl": "http://www.acclaro.com/",

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## 3.4.3- 2025-01-13
+
+### Fixed
+
+- An issue with Neo block propagation for non-localized blocks. ([AcclaroInc#562](https://github.com/AcclaroInc/pm-craft-translations/issues/562))
+
 ## 3.4.2 - 2024-12-16
 
 ### Fixed

diff --git a/src/services/fieldtranslator/NeoFieldTranslator.php b/src/services/fieldtranslator/NeoFieldTranslator.php
@@ -102,7 +102,7 @@ public function toPostArrayFromTranslationTarget(ElementTranslator $elementTrans
             $i = 'new' . ++$new;
 
             $isTranslatable = $field->getIsTranslatable($element);
-            $blockId = $isTranslatable ? $i : $this->getBlockUid($block);
+            $blockId = $isTranslatable ? $i : $block->id;
             $blockData = $allBlockData[$i] ?? array();
 
             $data = array(                
@@ -163,7 +163,7 @@ public function toPostArray(ElementTranslator $elementTranslator, Element $eleme
 
         foreach ($blocks as $i => $block) {
             $isTranslatable = $field->getIsTranslatable($element);
-            $blockId = $isTranslatable ? $i : $this->getBlockUid($block);
+            $blockId = $isTranslatable ? $i : $block->id;
 
             $data = array(
                 'modified' => '1',
@@ -183,9 +183,4 @@ public function toPostArray(ElementTranslator $elementTranslator, Element $eleme
 
         return $post;
     }
-
-    private function getBlockUid($block)
-    {
-        return sprintf('uid:%s', $block->getCanonicalUid());
-    }
 }