copy of Header.js from beacon scroll fix #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if these changes should be pulled into this project or not...
Finished fixing the scroll bug on beacon where if the page size was under a certain level the scroll wouldn't work as the code was stuck in a loop of removing the header shortening the scroll bar, shortened enough to where the current position becomes the bottom of the page and still be pushed up in scroll position, and this triggering a scroll up event.
This is all tied to the menu toggling whether the header should be position relative or fixed, so when they scroll up the header appears. This logic is handled by the fixed-top class being toggled based on having scrolled over X amount away from the top. This doesn't look to be really used by the existing Header.js in this project though so not sure if this fix is unique to beacon or if it needed to be pulled into AccuTheme as well.