Skip to content

Commit

Permalink
deprecated bounce tags
Browse files Browse the repository at this point in the history
  • Loading branch information
ibalosh committed Nov 12, 2019
1 parent 9e5ff97 commit 29fd2b2
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 28 deletions.
4 changes: 0 additions & 4 deletions lib/postmark/api_client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,6 @@ def get_bounces(options = {})
batch
end

def get_bounced_tags
http_client.get("bounces/tags")
end

def get_bounce(id)
format_response http_client.get("bounces/#{id}")
end
Expand Down
4 changes: 0 additions & 4 deletions lib/postmark/bounce.rb
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,6 @@ def all(options = {})
Bounce.new(bounce_json)
end
end

def tags
Postmark.api_client.get_bounced_tags
end
end

end
Expand Down
2 changes: 1 addition & 1 deletion lib/postmark/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Postmark
VERSION = '1.19.0'
VERSION = '1.19.1'
end
9 changes: 0 additions & 9 deletions spec/unit/postmark/api_client_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -398,15 +398,6 @@
end
end

describe "#get_bounced_tags" do
let(:http_client) {subject.http_client}

it 'requests data at /bounces/tags' do
expect(http_client).to receive(:get).with("bounces/tags")
subject.get_bounced_tags
end
end

describe "#get_bounce" do
let(:http_client) {subject.http_client}
let(:id) {42}
Expand Down
10 changes: 0 additions & 10 deletions spec/unit/postmark/bounce_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,4 @@
expect(Postmark::Bounce.all.count).to eq(3)
end
end

describe ".tags" do
let(:api_client) { Postmark.api_client }
let(:tags) { ["tag1", "tag2"] }

it "calls #get_bounced_tags on shared api_client instance" do
expect(api_client).to receive(:get_bounced_tags) { tags }
expect(Postmark::Bounce.tags).to eq tags
end
end
end

0 comments on commit 29fd2b2

Please sign in to comment.