Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zen Browser to browser list #625

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Senophyx
Copy link

@Senophyx Senophyx commented Jan 16, 2025

Since i'm using Zen as my primary browser and Zen is not on the list, I can't see detail activity on "Browser" tab even though Zen is a Firefox fork. So i add Zen Browser to browser list.

Zen Browser website


Important

Add Zen Browser to browser_appnames in queries.ts to enable activity tracking.

  • Behavior:
    • Add Zen Browser to browser_appnames in queries.ts with identifiers: 'Zen Browser', 'zen browser', 'zen.exe'.
    • Enables activity tracking for Zen Browser in the "Browser" tab.

This description was created by Ellipsis for ce17f9d. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ce17f9d in 9 seconds

More details
  • Looked at 16 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_hg9Iwxnts9GocMaw


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@BelKed
Copy link
Contributor

BelKed commented Jan 16, 2025

Just remember that data from the Zen Browser is collected in the aw-watcher-web-firefox bucket.
This means that even after this PR, you won't be able to see the data on the Dashboard.

@Senophyx
Copy link
Author

But after I followed this, it worked and the data from Zen can be displayed in the browser tab. So I think this PR can also fix the issue without having to edit the file manually. Is that not related to this PR?

image

Copy link
Contributor

@BelKed BelKed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider also adding app.zen_browser.zenhttps://flathub.org/apps/app.zen_browser.zen

src/queries.ts Outdated Show resolved Hide resolved
@ErikBjare
Copy link
Member

@Senophyx But you modified the firefox entry and didn't add a new zen entry, right? Isn't your bucket name aw-watcher-web-firefox?

@BelKed
Copy link
Contributor

BelKed commented Feb 6, 2025

Data from Zen Browser are saved to aw-watcher-web-firefox, just tested it on my end :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants