Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Macaria #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Branches - Macaria #29

wants to merge 1 commit into from

Conversation

mdove92
Copy link

@mdove92 mdove92 commented Nov 17, 2019

…tons.

JS Adagrams

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I translated each loops into forEach loops and I got to change my case when into a switch case!
Did you need to use different strategies to find information online about JavaScript than you would for Ruby? I used similar tactics to find information online about Javascript.
What was a challenge you were able to overcome on this assignment? I had to overcome finding the write place to put curly brackets and when to use parentheses! I downloaded a formatter to help me, but it was still hard to understand when and where I needed to add them.
What has been interesting and positive about learning a new programming language? It's been fun seeing the patterns between the two languages. I can learnn this 2nd language much quicker than I did Ruby.
What is something to focus on your learnings in JavaScript in the next week? I need to figure out anonymous function syntax!

@jmaddox19
Copy link

JS Adagrams

What We're Looking For

Feature Feedback
General
Answered comprehension questions x
Small commits with meaningful commit messages It looks like you forgot to make incremental commits as you were working.
Code Requirements
drawLetters method x
Uses appropriate data structure to store the letter distribution x
All tests for drawLetters pass x
usesAvailableLetters method x
All tests for usesAvailableLetters pass x
scoreWord method x
Uses appropriate data structure to store the letter scores Technically doesn't use a data structure but I think this is great too
All tests for scoreWord pass x
Optional
highestScoreFrom method nope
Appropriately handles edge cases for tie-breaking logic nope
All tests for highestScoreFrom pass nope
Overall Great work!

beccaelenzil added a commit to beccaelenzil/js-adagrams that referenced this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants