Branches - Amal #34
Open
Branches - Amal #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS AdagramsWhat We're Looking For
Great work on this project, Amal! I have no complaints. I have a few comments on how to make this more "javascript-y" in syntax and code style. Otherwise, great work! Also, sorry about how late this grading is. Let me know if you have any questions |
tildeee
reviewed
Nov 27, 2019
| let hand = []; | ||
|
|
||
| for (let i = 0; i < 10; i += 1) { | ||
| const randomIndex = Math.floor(Math.random() * 99); |
There was a problem hiding this comment.
Where does this 99 come from? If it represents something (like the length of letterPool), maybe give it a variable name. If it doesn't, then how can we make this number meaningful?
tildeee
reviewed
Nov 27, 2019
| if (handObj[letter]){ | ||
| handObj[letter] -= 1; | ||
| if (handObj[letter] == 0) { | ||
| delete handObj[letter]; |
There was a problem hiding this comment.
Instead of using this delete command, it'd be better to set handObj[letter] = null
tildeee
reviewed
Nov 27, 2019
|
|
||
| scoreWord(word) { | ||
| let score = 0; | ||
| let letterScore = { |
beccaelenzil
added a commit
to beccaelenzil/js-adagrams
that referenced
this pull request
Jun 2, 2022
Revert "remove @babel line from babel.config"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS Adagrams
Congratulations! You're submitting your assignment!
Comprehension Questions