Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branches C. Gutierrez #49

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

CEsGutierrez
Copy link

JS Adagrams

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Method logic transfers okay to the basic driver for functions.
Did you need to use different strategies to find information online about JavaScript than you would for Ruby? Sort of, there are a lot more posts on it on resources like Stack Overflow so I feel like I could rely less on official documentation
What was a challenge you were able to overcome on this assignment? It took a long time for me to figure out how to create functions that had a cascading effect where they could call each other and then pass back a single response. My earlier attempts had scope issues.
What has been interesting and positive about learning a new programming language? I feel like a second language makes me more aware of syntax choices and structure.
What is something to focus on your learnings in JavaScript in the next week? Having more compound / compact functions rather than having a lot of teeny helper functions.

@CheezItMan
Copy link

JS Adagrams

What We're Looking For

Feature Feedback
General
Answered comprehension questions Check, lots of teeny helper functions are a good practice.
Small commits with meaningful commit messages Check, good commit messages, granular commits
Code Requirements
drawLetters method Check
Uses appropriate data structure to store the letter distribution Check
All tests for drawLetters pass Check
usesAvailableLetters method Check
All tests for usesAvailableLetters pass Check
scoreWord method Check
Uses appropriate data structure to store the letter scores Check
All tests for scoreWord pass Check
Overall Well done, you hit all the learning goals here. Nice work!

let bucket = [];

// iterates over array, defining the letter and value. It then pushes the letter into the bucket array according to the value
for ( const character in alphaRef ) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice

}
}

for(let i = 0; i < input.length; i++) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest moving away from these old-fashioned for loops and toward forEach and other loops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants