Snow Leopards - Aretta B. #127
Conversation
|
|
||
| const letters = Object.keys(letterPool); | ||
| let hand = []; | ||
| while (hand.length < 10) { |
There was a problem hiding this comment.
Nice job creating the hand! I'm not seeing where you account for the distribution of letters though. Seems like all letters have an equal chance of being selected.
There was a problem hiding this comment.
Sorry to seem like I'm being sensitive over this because I see I you still gave me green on this assignment and I appreciate it, but I really thought I got it right. I even ran to test 10 times in a row to make sure it worked. To my understanding, while const object keys are immutable their values aren't, so every time the loop ran can choose a letter from the list of keys it would go back and subtract from the value of that letter in the letter pool. The letter only got added to the hand if its matching value was above 0. Maybe I didn't do line 37 correctly. Please let me know.
There was a problem hiding this comment.
No problem! The function is getting letters from letterPool just fine, but it isn't accounting for the distribution of letters, so it should be the case that because the letter pool should contain 9 Is and 1 J, that it's 9 times more likely to draw an I. Think of it in an array form, simplified:
['A', 'A', 'A', 'A', 'A', 'A', 'A', 'A', 'A', 'B', 'B',...]
If we generated a random index based on the length of this array, it would be much more likely to be an A. But yours works a bit differently. You generate a number between 1 and 26 and that is used as an index to key off of the letterPool object, so all letters have a 1 in 26 chance of being selected, whereas in the array above, if we created an array that had all the letters according to their distribution, which would produce an array of size 98, we'd end up with a 9/98 chance of drawing an A. As for the decrementing, you're right that you need to decrement the value of each letter in the letter pool to make sure there are available tiles to draw and put into the hand, but there's a mismatch between letters and letterPool which is why the distribution of letters isn't accurate.
| }; | ||
|
|
||
| export const usesAvailableLetters = (input, lettersInHand) => { | ||
| // Implement this method for wave 2 | ||
| const testWord = input.toUpperCase(); |
| }; | ||
|
|
||
| export const scoreWord = (word) => { | ||
| // Implement this method for wave 3 | ||
| const scoreChart= { |
There was a problem hiding this comment.
This score chart object could be moved into the main scope so it wouldn't be created each time the function scoreWord is called. Also, note the object keys in JavaScript don't need quotes.
|
|
||
|
|
||
| const scoredWordsArray = Array.from(scoredWords.entries()); | ||
| function checkWord(word) { |
There was a problem hiding this comment.
Since checkWord is only used in the filter callback, it would be tidier to write the filter function with an inline anonymous arrow function, i.e.
const highScoreWords = scoredWordsArray.filter(word => word[1] === highscore);| const highScoreWords = scoredWordsArray.filter(checkWord) | ||
|
|
||
|
|
||
| let smallestWordLength = Infinity |
There was a problem hiding this comment.
There's some accidental indentation starting here on line 128 through 140.
| }; | ||
|
|
||
| export const highestScoreFrom = (words) => { | ||
| // Implement this method for wave 4 | ||
| const scoredWords = new Map(); |
There was a problem hiding this comment.
The highestScoreFrom function works great! I'd suggest simplifying the data structure transformations wherever possible, e.g. setting up a Map object isn't doing anything that a plain object can't.
| @@ -145,7 +147,7 @@ describe("Adagrams", () => { | |||
| const words = ["XXX", "XXXX", "X", "XX"]; | |||
| const correct = { word: "XXXX", score: scoreWord("XXXX") }; | |||
|
|
|||
| throw "Complete test by adding an assertion"; | |||
| expect(highestScoreFrom(words)).toEqual(correct); | |||
| scoredWords.set(word,scoreWord(word)); | ||
| }); | ||
|
|
||
| let scores = scoredWords.values(); |
There was a problem hiding this comment.
I don't see where these variables are reassigned, so they should be const
No description provided.