Ruby - Rediet Medhane #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate_task helper function
…invalid data post requests
Comment on lines
+34
to
+36
| from .routes import task_bp, goal_bp | ||
| app.register_blueprint(task_bp) | ||
| app.register_blueprint(goal_bp) |
Comment on lines
+9
to
+22
| def to_dict(self): | ||
| #tasks = [task.to_dict() for task in self.tasks] | ||
| return { | ||
| "id" : self.goal_id, | ||
| "title" : self.title | ||
|
|
||
| } | ||
| def to_dict_with_tasks(self): | ||
| tasks = [task.to_dict_with_goal() for task in self.tasks] | ||
| return { | ||
| "id" : self.goal_id, | ||
| "title" : self.title, | ||
| "tasks" : tasks | ||
| } |
There was a problem hiding this comment.
Yay, helper methods! However, these two are very, very similar. For the one with tasks, you can call the regular to_dict and then just add the lists of tasks to the dictionary that's returned.
Comment on lines
+13
to
+36
| def to_dict(self): | ||
| if self.completed_at: | ||
| is_complete = True | ||
| else: | ||
| is_complete = False | ||
| return { | ||
| "id" : self.task_id, | ||
| "title" : self.title, | ||
| "description" : self.description, | ||
| "is_complete" : is_complete | ||
| } | ||
|
|
||
| def to_dict_with_goal(self): | ||
| if self.completed_at: | ||
| is_complete = True | ||
| else: | ||
| is_complete = False | ||
| return { | ||
| "id" : self.task_id, | ||
| "title" : self.title, | ||
| "description" : self.description, | ||
| "is_complete" : is_complete, | ||
| "goal_id": self.goal_id | ||
| } |
There was a problem hiding this comment.
Yay, helper methods! Again, these are very, very similar. Only one is needed. The to_dict method can check to see if the task has a goal_id. If it does, add it to the dictionary.
| def test_get_task_not_found(client): | ||
| # Act | ||
| response = client.get("/tasks/1") | ||
| response_body = response.get_json() | ||
|
|
||
| # Assert | ||
| assert response.status_code == 404 | ||
| assert not response_body |
| @@ -130,14 +126,10 @@ def test_update_task_not_found(client): | |||
|
|
|||
| # Assert | |||
| assert response.status_code == 404 | |||
| assert not response_body | |||
|
|
||
| @goal_bp.route("/<goal_id>", methods = ["GET"]) | ||
| def get_goal_by_id(goal_id): |
|
|
||
| @goal_bp.route("/<goal_id>", methods = ["PUT"]) | ||
| def update_one_goal(goal_id): |
|
|
||
| @goal_bp.route("/<goal_id>", methods = ["DELETE"]) | ||
| def delete_one_goal(goal_id): |
| tasks.append(validate_item(Task, task_id)) | ||
|
|
||
| goal.tasks = tasks |
There was a problem hiding this comment.
If the goal already had tasks attached to it, this would get rid of them. It would be better to append the tasks.
|
|
||
| @goal_bp.route("/<goal_id>/tasks", methods = ["GET"]) | ||
| def get_tasks_of_one_goal(goal_id): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.