Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jan Edrozo | Carets #26

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Jan Edrozo | Carets #26

wants to merge 20 commits into from

Conversation

JNEdrozo
Copy link

@JNEdrozo JNEdrozo commented Dec 4, 2017

BackTREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What role does the Model play in Backbone? In Backbone, the model plays a similar role to rails models. The models in Backbone allow us to organize data and business logic (e.g. validations and custom methods are placed in the model); they interact with the server by loading and saving data to and from the server, and they can help us keep track of changes by emitting events when data changes.
How did the presence of Models and Collections change the way you thought about your app? The presence of models and collections helped me better conceptualize how to organize business logic and implement OOD (e.g. how does Trip and Reservation models interact and how do they relate to each other). It was also neat to be able to implement event listeners on collections like the tripList to notify the app when an update (e.g. fetch request) was completed to re-render a view.
How do Backbone Events compare to DOM events? Backbone events involve changes made to the data/model/collections (e.g. when a collection is updated), while DOM events involve user-related changes (e.g. when someone clicks on a button).
How did you approach filtering? What was your data flow for this feature? Not yet implemented, but hoping to implement this week (in addition to adding more styling)
What do you think of Backbone in comparison to raw JavaScript & jQuery? I like the structural support.
Do you have any recommendations on how we could improve this project for the next cohort? More information/lecture on webpack -- like how it works with styling; how to configure webpack from the beginning so we understand what to import and use additional plugins if they are necessary. (For example, I was unable to change the favicon and wasn't sure if I needed the following plugin: https://www.npmjs.com/package/html-webpack-plugin). Maybe not make this the project before interviews?

…stener so upon clicking a trip's row, a single trip's info is fetch (still need to work on its display)
…m reservation form rather than use my test reservation variable)
…ng spaces before or after name); Modified: Reservation Form & logic so fields are defined when submitting reservation
…trip model validations to enable loading of tripList; also cleaned up status message modal headings
…t add new trip modal messages still work in conjunction with reservation modal messages
…t already exists, and changed the status modal from ReservationStatusModal to statusMessageModal(to have 1 status message modal)
… down menu; also added images (saved to images folder only)
@kariabancroft
Copy link

BackTREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good
Comprehension questions Yes
Organization
Models and collections are defined in separate files Yes
Code that relies on the DOM is located in or called by $(document).ready Yes
Code follows the Backbone data flow (DOM event -> update model or collection -> Backbone event -> update DOM) Yes
Functionality
Display list of trips Good
Display trip details Good
Register for a trip Good - I think it is a bit odd that the reservation model object creation is within the trip model object. Normally, we wouldn't want to have these models rely on one another since the Trip model can (and should) be created without any knowledge of the Reservation model.
Add a trip Good
Sort trips Good
General
Snappy visual feedback for user actions Yes
API error handling Yes - nice job having success and failure event functions
Client-side validation Yes - here is an opportunity to DRY things up since the #status-messages logic is duplicated in a few places.
Overall Nice job on this - you hit the major learning goals on this assignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants