Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes - Sara Frandsen -Back Trek #31

Open
wants to merge 46 commits into
base: master
Choose a base branch
from

Conversation

frankienakama
Copy link

BackTREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What role does the Model play in Backbone? Models contain a lot of the logic in the JS--validations, defaults, access control, etc. Similar to Rails models.
How did the presence of Models and Collections change the way you thought about your app? It was nice having a separate document keeping track of the basic information of specific pieces of the app that I could easily refer back to.
How do Backbone Events compare to DOM events? Backbone events refer to the API events (such as .fetch()) and DOM events refer to the user/page interactions (such as .click())
How did you approach filtering? What was your data flow for this feature? I did not do any filtering
What do you think of Backbone in comparison to raw JavaScript & jQuery? I felt like it was supposed to be helpful, but only added to the confusing mess that is JS
Do you have any recommendations on how we could improve this project for the next cohort?

Sara Frandsen added 30 commits November 28, 2017 15:34
… a single trip so now the 'about' description appears when clicked
@CheezItMan
Copy link

BackTREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits and good commit messages
Comprehension questions Check, note Backbone event occur when the data changes as opposed to user activity
Organization
Models and collections are defined in separate files Check
Code that relies on the DOM is located in or called by $(document).ready Check
Code follows the Backbone data flow (DOM event -> update model or collection -> Backbone event -> update DOM)
Functionality
Display list of trips Check, but if I add a trip, I can't see the list anymore. I have to refresh to see the trip list again.
Display trip details Check
Register for a trip Check, however no feedback to see if the registration is successful
Add a trip Check, however no feedback about success or failure
Sort trips Check
General
Snappy visual feedback for user actions The layout is good and the interface is nice, but you don't provide any feedback to the user
API error handling MISSING you have the event handlers, but you weren't doing anything with the information
Client-side validation MISSING
Overall You covered many of the learning goals of this project, but are missing client-side and server-side validations. That's something I'd like you to work on for the next project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants