Lauren Cardella -- Carets #29

enigmagnetic · 2017-11-06T12:29:13Z

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I read the documentation, then tried two different queries in Postman, one using the q key (for a recipe search by keyword) and one using the r key (to return a recipe by ID).
Describe your API Wrapper. How did you decide on the methods you created?	I created two methods for my API Wrapper, one to return a list of search results (used in the recipes controller index action) and the other to return a particular recipe (used in the recipes controller show action).
Describe an edge case or failure case test you wrote for your API Wrapper.	I wrote an edge case test for both API Wrapper methods to make sure that an invalid argument returns an empty array.
Explain how VCR aids in testing an API.	VCR records the API responses for a given call so that it can be used in subsequent matching calls. This helps reduce the number of calls made to the API (so that the tests don't contribute to any limits), speeds the tests up because new calls are not needed for each test, and it allows for testing even when the API service is down.
What is the Heroku URL of your deployed application?	https://muncher-ada.herokuapp.com/

…s. Add .env to .gitignore.

…page. Create recipes controller.

…ex. Edit application and recipe index views. Search not returning any results.

…ontroller.

…index view. Build show action in recipes controller. Add uri instance variable to recipe.rb and make some info into optional variables.

…pi wrapper.

…use array data. Change index action to include paginate method. Add pagination to recipes index view.

…ts to api wrapper tests.

…d api wrapper.

CheezItMan · 2017-11-07T21:49:36Z

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commits and good commit messages
Comprehension questions	Check
General
Rails fundamentals (RESTful routing, use of named paths)	Check
Semantic HTML	Check, although your index page has a `div` that could be something else
Errors are reported to the user	No search results reported for invalid searches. It crashes for invalid URIs for individual recipes
API Wrapper to handle the API requests	Check, although you need to work on error handling
Controller testing	2 failing tests
Lib testing	Check, but a failing test due to lack of error handling in your wrapper
Search Functionality	Check
List Functionality	Check
Show individual item functionality (link to original recipe opens in new tab)	Check
Styling
Foundation Styling for responsive layout	Well done
List View shows 10 items at a time/pagination	Check
The app is styled to create an attractive user interface	Check
API Features
The App attributes Edaman	Yes, but no link.
The VCR casettes do not contain the API key	Check
External Resources
Link to deployed app on Heroku	Doesn't work!
Overall	Your Heroku isn't working and you have trouble with negative case tests as well as some error handling in your wrapper. Not bad, but could be better.

CheezItMan · 2017-11-07T21:41:29Z

lib/edamam_api_wrapper.rb

+
+    data = HTTParty.get(url)
+
+    unless data.empty?


I would add a rescue because for bad requests data is coming back as [ which won't parse correctly.

CheezItMan · 2017-11-07T21:47:44Z

app/views/recipes/index.html.erb

+<% else %>
+  <% @recipes.each do |recipe| %>
+    <article class="recipe">
+      <%= image_tag (recipe.image) %>


I would make the images for the results links as it's natural to want to click on'em.

CheezItMan · 2017-11-07T21:50:35Z

test/controllers/recipes_controller_test.rb

+    it "can get a list of recipe search results" do
+      VCR.use_cassette("index_action") do
+        get recipes_path
+        must_respond_with :success


If there's not a search here it redirects back to home.

CheezItMan · 2017-11-07T21:51:17Z

test/controllers/recipes_controller_test.rb

+  describe "show" do
+    it "can get a specific recipe" do
+      VCR.use_cassette("show_action") do
+        get recipe_path


There's no recipe to show, so it redirects to the homepage, at least I'd hope so, or prints an error message.

enigmagnetic added 24 commits October 31, 2017 02:42

Initialize rails application. Add and install dotenv and httparty gem…

d0dfc94

…s. Add .env to .gitignore.

Add copyright and attribution to footer. Create root route to search …

1314df5

…page. Create recipes controller.

Add header to application html. Change heading on search page.

d424bbe

Add wrapper for Edamam API. Define Recipe class with initialize method.

7705b7c

Add search form to search/root view. Clean up routes.

4da0af4

Build wrapper for Edamam Api. Build recipe model.

ec8a701

Add routes for search form and root. Add autoload to application.rb.

f83d581

Edit actions in recipes controller to remove search and build out ind…

8be7aa1

…ex. Edit application and recipe index views. Search not returning any results.

Got recipes index working.

5e1bb1a

Add link to recipe show page. Start building show action in recipes c…

f372a70

…ontroller.

Edit root path.

1087047

Add find_recipe method to API wrapper. Add uri param to show link in …

e6e3601

…index view. Build show action in recipes controller. Add uri instance variable to recipe.rb and make some info into optional variables.

Build recipe show page. Add health and diet labels to recipe.rb and a…

91ff41e

…pi wrapper.

Add will_paginate gem. Add initalizer file to allow will_paginate to …

eca6090

…use array data. Change index action to include paginate method. Add pagination to recipes index view.

Clean up unused routes.

d2bbb21

Add VCR and webmock gems.

017f7d6

Add require statements to test_helper. Add test files and initial tes…

96cb24b

…ts to api wrapper tests.

Add tests with VCR cassettes for recipes controller, recipe model, an…

e18018c

…d api wrapper.

Configure VCR in test helper. Create and migrate database.

ef276cf

Add show page styling.

5b60905

Style index page.

2bf2039

Possible fix for heroku depoyment error.

0d9a65c

Heroku deploy fix did not work.

fe2516f

Fix application css for heroku deployment.

2ab368b

CheezItMan reviewed Nov 7, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lauren Cardella -- Carets #29

Lauren Cardella -- Carets #29

enigmagnetic commented Nov 6, 2017

CheezItMan commented Nov 7, 2017

CheezItMan Nov 7, 2017

CheezItMan Nov 7, 2017

CheezItMan Nov 7, 2017

CheezItMan Nov 7, 2017

Lauren Cardella -- Carets #29

Are you sure you want to change the base?

Lauren Cardella -- Carets #29

Conversation

enigmagnetic commented Nov 6, 2017

API Muncher

Comprehension Questions

CheezItMan commented Nov 7, 2017

API Muncher

What We're Looking For

CheezItMan Nov 7, 2017

Choose a reason for hiding this comment

CheezItMan Nov 7, 2017

Choose a reason for hiding this comment

CheezItMan Nov 7, 2017

Choose a reason for hiding this comment

CheezItMan Nov 7, 2017

Choose a reason for hiding this comment