Skip to content

Commit

Permalink
Generate empty javadoc for cloud bundle fragment (#3272)
Browse files Browse the repository at this point in the history
Remove artificial public interface
This closes #3200
  • Loading branch information
kwin authored Mar 8, 2024
1 parent dc54035 commit 2bc2400
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 49 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com)
### Fixed

- #3270 - Re-enable accidentally disabled JUnit3/4 tests
- #3200 - Remove useless public interface in Cloud Bundle to get javadocs to be built

## 6.4.0 - 2024-02-22

Expand Down
36 changes: 36 additions & 0 deletions bundle-cloud/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ Fragment-Host: com.adobe.acs.acs-aem-commons-bundle
<plugin>
<groupId>biz.aQute.bnd</groupId>
<artifactId>bnd-baseline-maven-plugin</artifactId>
<configuration>
<skip>true</skip><!-- temporarily ignore due to empty interface being exported in 6.3.x -->
</configuration>
</plugin>
<plugin>
<groupId>org.apache.sling</groupId>
Expand Down Expand Up @@ -115,4 +118,37 @@ Fragment-Host: com.adobe.acs.acs-aem-commons-bundle
<scope>provided</scope>
</dependency>
</dependencies>

<profiles>
<profile>
<id>release</id>
<activation>
<property>
<name>performRelease</name>
</property>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<executions>
<!-- generate empty jar, as long as no javadoc is generated -->
<execution>
<id>javadoc-jar</id>
<phase>package</phase>
<goals>
<goal>jar</goal>
</goals>
<configuration>
<classesDirectory>${project.build.directory}/invalid</classesDirectory>
<classifier>javadoc</classifier>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>
30 changes: 0 additions & 30 deletions bundle-cloud/src/main/java/com/adobe/acs/commons/CloudBundle.java

This file was deleted.

19 changes: 0 additions & 19 deletions bundle-cloud/src/main/java/com/adobe/acs/commons/package-info.java

This file was deleted.

0 comments on commit 2bc2400

Please sign in to comment.