[ECP-8663] Remove usage of brand_code argument #2902
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 28, 2025 09:21
# Conflicts: # Observer/AdyenPaymentMethodDataAssignObserver.php
candemiralp
had a problem deploying
to
internal
GitHub Actions
Failure
candemiralp
had a problem deploying
to
internal
GitHub Actions
Failure
candemiralp
had a problem deploying
to
internal
GitHub Actions
Failure
candemiralp
had a problem deploying
to
internal
GitHub Actions
Failure
candemiralp
had a problem deploying
to
internal
GitHub Actions
Failure
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The plugin contains a left-over code from V8 to determine the type of the alternative payment method brand under
adyen_hppumbrella. This is not required anymore as the payment methods have been implemented separately.This PR cleans-up the usage of
brand_codeargument in the plugin.Tested scenarios