- client: timezone reflects daylight savings time (Win)

from David Barnard; fixes BOINC#334 - GUI RPC: add <success/> replies for ops that don't return anything - GUI RPC: check args for project_attach - GUI RPC: return error (not blank) if no prefs override file - add error string for ERR_TOO_MANY_EXITS svn path=/trunk/boinc/; revision=13293
AenBleidd · Aug 10, 2007 · 2cd158a · 2cd158a
1 parent b6952dc
commit 2cd158a
Show file tree

Hide file tree

Showing 6 changed files with 41 additions and 18 deletions.
diff --git a/checkin_notes b/checkin_notes
@@ -7724,3 +7724,17 @@ Rom    8 Aug 2007
     clientgui/res/templates/
         boincsnooze.ico
         boincdisconnect.ico
+
+David  10 Aug 2007
+    - client: timezone reflects daylight savings time (Win)
+        from David Barnard; fixes #334
+    - GUI RPC: add <success/> replies for ops that don't return anything
+    - GUI RPC: check args for project_attach
+    - GUI RPC: return error (not blank) if no prefs override file
+    - add error string for ERR_TOO_MANY_EXITS
+
+    client/
+        gui_rpc_server_ops.C
+        hostinfo_win.C
+    lib/
+        str_util.C
diff --git a/checkin_notes_2005 b/checkin_notes_2005
@@ -1,4 +1,4 @@
-David  1 Jan 2005
+eavid  1 Jan 2005
     - Deprecated the bad hash function used for the
         upload/download directory hierarchies.
         It wasn't uniform.

diff --git a/client/gui_rpc_server_ops.C b/client/gui_rpc_server_ops.C
@@ -593,8 +593,9 @@ static void handle_get_cc_status(GUI_RPC_CONN* gr, MIOFILE& fout) {
     );
 }
 
-static void handle_network_available(char*, MIOFILE&) {
+static void handle_network_available(char*, MIOFILE& fout) {
     net_status.network_available();
+    fout.printf("<success>\n");
 }
 
 static void handle_get_project_init_status(char*, MIOFILE& fout) {
@@ -637,6 +638,10 @@ static void handle_lookup_account(char* buf, MIOFILE& fout) {
     ACCOUNT_IN ai;
 
     ai.parse(buf);
+    if (!ai.url.size() || !ai.email_addr.size() || !ai.passwd_hash.size()) {
+        fout.printf("<error>missing URL, email address, or password</error>\n");
+        return;
+    }
 
     gstate.lookup_account_op.do_rpc(ai);
     fout.printf("<success/>\n");
@@ -833,6 +838,8 @@ static void handle_get_global_prefs_override(MIOFILE& fout) {
     if (!retval) {
         strip_whitespace(s);
         fout.printf("%s\n", s.c_str());
+    } else {
+        fout.printf("<error>no prefs override file</error>\n");
     }
 }
 
@@ -1107,6 +1114,7 @@ int GUI_RPC_CONN::handle_rpc() {
     } else if (match_tag(request_msg, "<acct_mgr_info")) {
         handle_acct_mgr_info(request_msg, mf);
     } else if (match_tag(request_msg, "<read_global_prefs_override/>")) {
+        mf.printf("<success>\n");
         gstate.read_global_prefs();
         gstate.request_schedule_cpus("Preferences override");
         gstate.request_work_fetch("Preferences override");
@@ -1125,6 +1133,7 @@ int GUI_RPC_CONN::handle_rpc() {
     } else if (match_tag(request_msg, "<set_cc_config")) {
         handle_set_cc_config(request_msg, mf);
     } else if (match_tag(request_msg, "<read_cc_config/>")) {
+        mf.printf("<success>\n");
         read_config_file();
         gstate.request_schedule_cpus("Core client configuration");
         gstate.request_work_fetch("Core client configuration");

diff --git a/client/hostinfo_win.C b/client/hostinfo_win.C
@@ -87,15 +87,14 @@ struct INTERNALMONITORINFO
 // Returns the number of seconds difference from UTC
 //
 int get_timezone(int& timezone) {
-
     TIME_ZONE_INFORMATION tzi;
-
-	memset(&tzi, '\0', sizeof(TIME_ZONE_INFORMATION));
-
-    GetTimeZoneInformation(&tzi);
-
-    timezone = -(tzi.Bias * 60);
-
+	memset(&tzi, 0, sizeof(TIME_ZONE_INFORMATION));
+    DWORD result = GetTimeZoneInformation(&tzi);
+    if (result == TIME_ZONE_ID_DAYLIGHT) {
+        timezone = -(tzi.DaylightBias * 60);
+    } else {
+        timezone = -(tzi.StandardBias * 60);
+    }
     return 0;
 }
 

diff --git a/doc/email_lists.php b/doc/email_lists.php
@@ -27,36 +27,36 @@
 ";
 list_start();
 list_item(
-    "<a href=http://ssl.berkeley.edu/mailman/listinfo/boinc_announce>boinc_announce</a>",
+    "<a href=http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_announce>boinc_announce</a>",
     "Announcements of new versions of BOINC client software."
 );
 list_item(
-    "<a href=http://ssl.berkeley.edu/mailman/listinfo/boinc_projects>boinc_projects</a>",
+    "<a href=http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_projects>boinc_projects</a>",
     "For people developing and operating BOINC projects.
     Questions and problems involving BOINC API and server software.
     Announcements of upgrades and changes.
 ");
-list_item("<a href=http://ssl.berkeley.edu/mailman/listinfo/boinc_dev>boinc_dev</a>",
+list_item("<a href=http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev>boinc_dev</a>",
     "For people developing, debugging or porting the BOINC software
     (client, server, and Web).
     Do NOT post questions about how to use the software.
 ");
-list_item("<a href=http://ssl.berkeley.edu/mailman/listinfo/boinc_loc>boinc_loc</a>",
+list_item("<a href=http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_loc>boinc_loc</a>",
     "For people doing non-English translations
     of the BOINC GUI or web interfaces.
 ");
 list_item(
-    "<a href=http://www.ssl.berkeley.edu/mailman/listinfo/boinc_stats>boinc_stats</a>",
+    "<a href=http://www.lists.ssl.berkeley.edu/mailman/listinfo/boinc_stats>boinc_stats</a>",
     "For people developing web sites showing statistics for BOINC projects."
 );
-list_item("<a href=http://ssl.berkeley.edu/mailman/listinfo/boinc_cvs>boinc_cvs</a>",
+list_item("<a href=http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_cvs>boinc_cvs</a>",
     "Summaries of BOINC CVS checkins are posted to this list.
     No other posts, please."
 );
-list_item("<a href=http://www.ssl.berkeley.edu/mailman/listinfo/boinc_opt>boinc_opt</a>",
+list_item("<a href=http://www.lists.ssl.berkeley.edu/mailman/listinfo/boinc_opt>boinc_opt</a>",
     "For people porting and optimizing BOINC applications."
 );
-list_item("<a href=http://www.ssl.berkeley.edu/mailman/listinfo/boinc_helpers>boinc_helpers</a>",
+list_item("<a href=http://www.lists.ssl.berkeley.edu/mailman/listinfo/boinc_helpers>boinc_helpers</a>",
     "For BOINC <a href=help.php>Help Volunteers</a>,
     to discuss policies and user problems."
 );

diff --git a/lib/str_util.C b/lib/str_util.C
@@ -676,6 +676,7 @@ const char* boincerror(int which_error) {
         case ERR_CHOWN: return "can't change owner";
         case ERR_FILE_NOT_FOUND: return "file not found";
         case ERR_BAD_FILENAME: return "file name is empty or has '..'";
+        case ERR_TOO_MANY_EXITS: return "application exited too many times";
         case 404: return "HTTP file not found";
         case 407: return "HTTP proxy authentication failure";
         case 416: return "HTTP range request error";