Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pot): create t0 t1 t2 computation logic #4

Merged

Conversation

Aeternalis-Ingenium
Copy link
Owner

  • Create directory structure: evals/, plots/,stats/, time_windows/.
  • Implement compute_pot_windows() function in anomalytics/time_windows/pot_windows.py.
  • Implement overload functions for set_time_window() which is a function that executes the respective time window computation based on the statistical method.
  • Import all time windows functions in init.py to make it comfortable for users.
  • Create unit test to ensure compute_pot_windows() calculate t0, t1, t2 correctly for "historical" and "real-time" analysis type.

closes #1
closes #2

This directory is to store the implementation of calculating the time windows needed for each statistical method e.g. POT with its t0, t1, t2 concept.
…window setup

The main idea is that each statistical method will have a different time window concept. Hence the repeated set_time_window as an overloaded function.
…_windows

The test should ensure that compute_pot_windows are executed from the correct set_time_window (overloaded function).
set_time_window is now accessible from anomalytics/__init__.py and compute_pot_windows now accessible from anomalytics/time_windows/__init__.py
Copy link

codecov bot commented Dec 3, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@Aeternalis-Ingenium Aeternalis-Ingenium merged commit f8c05cd into trunk Dec 3, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Time Window for POT Method Create Directory Structures
2 participants