Fixing a crash caused by a null URL.

Affirm · Feb 26, 2024 · f3e0186 · f3e0186
1 parent 09714fb
commit f3e0186
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/affirm/src/main/java/com/affirm/android/AffirmWebChromeClient.java b/affirm/src/main/java/com/affirm/android/AffirmWebChromeClient.java
@@ -7,6 +7,7 @@
 import android.os.Message;
 import android.webkit.ConsoleMessage;
 import android.webkit.JsResult;
+import android.webkit.URLUtil;
 import android.webkit.WebChromeClient;
 import android.webkit.WebView;
 
@@ -29,9 +30,14 @@ public boolean onCreateWindow(WebView view, boolean isDialog, boolean isUserGest
                                   Message resultMsg) {
         final WebView.HitTestResult result = view.getHitTestResult();
         final String data = result.getExtra();
-        final Context context = view.getContext();
-        final Intent browserIntent = new Intent(Intent.ACTION_VIEW, Uri.parse(data));
-        context.startActivity(browserIntent);
+        if (isUserGesture
+                && URLUtil.isNetworkUrl(data)
+                && result.getType() == WebView.HitTestResult.SRC_ANCHOR_TYPE) {
+            final Context context = view.getContext();
+            final Intent browserIntent = new Intent(Intent.ACTION_VIEW, Uri.parse(data));
+            context.startActivity(browserIntent);
+            return true;
+        }
         return false;
     }