Escalations #112
Open
Escalations #112
+48
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
trigger build |
| alert.send_alert(service, users, fallback_officers) | ||
| except Exception: | ||
| logging.exception('Could not send {} alert to fallback officer'.format(alert.name)) | ||
| for user_list in [duty_officers, escalation_officers, fallback_officers]: |
There was a problem hiding this comment.
Not sure I understand the logic here. Seems like your new code:
- Sends alerts to first non-empty officers list
- If successful, quit
- If an exception is thrown, check if we should escalate. If we are scheduled to escalate, then loop and alert the next set of officers. Else, quit.
Seems like if alerts are delivered successfully, we'll never escalate? Or am I missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@elainearbaugh @EvanKuhn-Affirm @BlaineAtAffirm
First pass idea for adding escalations.