Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kobotoolbox source #259
Add kobotoolbox source #259
Changes from all commits
3fff292
7f7f951
36fa7e7
9e3dfa7
5410d27
81aeaa3
2e0416a
089254e
8751a2a
edb4619
011b5eb
02fc23f
2fb3da6
02bfe25
f548c59
f18dd8a
7ca9466
f961a87
c8ff426
69d8ca4
7c363ed
93e74b9
5c997c0
3b97114
b958e83
a353720
4bf3abf
4450498
422c027
1d284e4
cee94a6
c12e46b
7665fe2
1cb1e4f
7e07b27
6fe4d9f
e596b40
c15d3a0
8888060
e49ce0f
769b389
12748d1
f778b62
9ec298c
a89ff17
1b5a5bf
276f66b
72b43a9
c340872
072709a
11119de
6c0c274
26d78c9
514a70b
1083a8d
c974246
59b5a1d
1304e93
a80d8b7
6129c4e
da0ac52
2670f86
f958992
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the client would be slightly easier to use if authentication was handled internally. Then uses would change from:
to:
The other clients were implemented in this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this use case needs explaining because it requires an explicit call to get the auth headers first. If the client took care of that automatically, as suggested above, then perhaps we don't need this example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we think this example is helpful, then we should think about the best way to format it. If, in the future, we enabled doctesting for this project then this docstring would fail. Is there another way to format examples that doesn't trigger a doctest, or a doctest-ignore directive we can use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit difficult to read because of all the curly braces and quotes. How about:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should talk about forms or the function should be called
get_asset
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it safe to disable the security checks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if there is no data because the request didn't succeed?