Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue- 1,2,3,4,5,6,7,14,22; added a A-long game Shivam Jaiswal_22053278 #19

Open
wants to merge 4 commits into
base: Participant
Choose a base branch
from

Conversation

shivamj62
Copy link

@shivamj62 shivamj62 commented Oct 2, 2023

Fixed All Issues

Proposed Changes

  • fixed the range for button in doors.py

  • made site A button 2 accessible

  • fixed the previously non functional slider in spawn.py

  • rounded edges and added outline to make subtle seperated look not just be on the same vertical plane as the slider

  • made the site A button images respond correctly to press.

  • fixed the functionality of button 5

  • added description to the functions as comments in doors.py

  • redesigned the A-long to make it consistent with app design and fixed the icon on map-screen to

Related Issues

  • Fixes # [1, 2, 3, 4, 5, 6, 7, A-long redesign]

Checklist

  • I have read the README.md document.
  • I have checked existing pull requests to ensure this is not a duplicate.
  • I have tested my changes thoroughly.
  • My contribution is legitimate and it abides by Hacktoberfest guidelines.

…per range | made site A button accesible | slider fixed |site A button image fixed | button functionality of site A fixed | added documnetation as comments to the functions in doors.py
Copy link
Collaborator

@PythonicBoat PythonicBoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivamj62 Thanks for contributing!
Give the repo a star ⭐

@shivamj62
Copy link
Author

@shivamj62 shivamj62 changed the title Issue [1,2,3,4,5,7], Shivam Jaiswal_22053278 Issue- 1,2,3,4,5,6,7,14,22; added a A-long game Shivam Jaiswal_22053278 Oct 4, 2023
@rycerzes rycerzes requested a review from PythonicBoat October 4, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants