-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install script #318
base: main
Are you sure you want to change the base?
Install script #318
Conversation
) | ||
|
||
APP_NAME="agentstack" | ||
VERSION="0.3.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could potentially create a GH workflow to dynamically update this whenever a change is made to the version number in pyproject.toml
install.sh
Outdated
} | ||
# TODO allow user to specify install path with --target | ||
# TODO allow user to specify Python version with --python-version | ||
# TODO uninstall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets prioritize getting this finished. i think we can leave these TODOs in and add tickets for them to get this merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay i see these are actually implemented below. if the todo is just to add an arg, send it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just forgot to delete 'em 🤓
_help_text="Hint: brew install $_cmd_name" | ||
fi | ||
err "A required dependency is missing. Please install: $*\n$_help_text" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see why gcc might be a blocker. def something to keep an eye on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple notes based on my research into this:
we can't handle the apt install for them because it needs sudo. although i've seen script prompt for a sudo password before.
we can install brew
in userspace on macos and then get gcc
. it comes with apple's dev tools, but that's a big package that not everyone has.
we can also install linuxbrew
in userspace and then get gcc
on linux/WSL.
uv
agentstack
into the system site-packages and puts a bin in~/.local/bin
Incorporate release version dynamically