Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script #318

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

Install script #318

wants to merge 26 commits into from

Conversation

tcdent
Copy link
Collaborator

@tcdent tcdent commented Feb 18, 2025

  • Installs uv
  • Installs a supported version of Python if one is not found
  • Installs agentstack into the system site-packages and puts a bin in ~/.local/bin
  • Make sure auto-updater works
  • SHA256 hashes of releases (https://github.com/thewh1teagle/checksum)
  • Verify hash validation works in script
  • Incorporate release version dynamically
  • Emoji
  • MacOS
  • uninstall

@tcdent tcdent changed the title WIP Install script Install script Feb 19, 2025
@tcdent tcdent requested a review from bboynton97 February 19, 2025 03:24
)

APP_NAME="agentstack"
VERSION="0.3.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could potentially create a GH workflow to dynamically update this whenever a change is made to the version number in pyproject.toml

install.sh Outdated
}
# TODO allow user to specify install path with --target
# TODO allow user to specify Python version with --python-version
# TODO uninstall
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets prioritize getting this finished. i think we can leave these TODOs in and add tickets for them to get this merged

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay i see these are actually implemented below. if the todo is just to add an arg, send it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just forgot to delete 'em 🤓

_help_text="Hint: brew install $_cmd_name"
fi
err "A required dependency is missing. Please install: $*\n$_help_text"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see why gcc might be a blocker. def something to keep an eye on

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple notes based on my research into this:

we can't handle the apt install for them because it needs sudo. although i've seen script prompt for a sudo password before.

we can install brew in userspace on macos and then get gcc. it comes with apple's dev tools, but that's a big package that not everyone has.

we can also install linuxbrew in userspace and then get gcc on linux/WSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants