calling flows from flows and other support for 9796 #10024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
84d3ea6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c2f4b9b2.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9796-support.agoric-sdk.pages.dev |
0xpatrickdev
approved these changes
Sep 4, 2024
Comment on lines
+27
to
+28
| // Osmosis is one of the few chains with icqEnabled | ||
| const osmosis = await orch.getChain('osmosis'); |
There was a problem hiding this comment.
omniflix appears to have icq enabled, but that's not to suggest we should revert this change. osmosis is preferable from my POV since it's integrated in multichain-testing - starship doesn't yet support omniflix.
| @@ -43,7 +43,7 @@ const preparePortfolioHolderKit = (zone, { asVow, when }) => { | |||
| 'PortfolioHolderKit', | |||
| { | |||
| invitationMakers: M.interface('InvitationMakers', { | |||
| MakeInvitation: M.call( | |||
| Proxying: M.call( | |||
There was a problem hiding this comment.
Wb Proxy, verb, instead of a present participle?
There was a problem hiding this comment.
That was my first thought too but since Proxy is a global object I thought it would be confusing.
mhofman
previously requested changes
Sep 4, 2024
turadg
commented
Sep 5, 2024
mhofman
reviewed
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9796
Description
#10023 started with a series of refactors and cleanup. This separates those into another PR to be reviewed more rapidly.
It also includes a new feature to orchestrateAll to ease calling flows from flows. Each flow is available on the context object under
flows.Security Considerations
Every flow can call another flow. In the event a developer wants isolate between flows, they won't put them in the same
orchestrateAll.Scaling Considerations
n/a
Documentation Considerations
none
Testing Considerations
new tests
Upgrade Considerations
not yet deployed