feat: UI to mint tickets #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
reviewed
Mar 13, 2024
| <ThemeProvider> | ||
| <div className={themeClass}> | ||
| <div> | ||
| <NetworkDropdown networkConfigs={[mainnet, localnet]} /> |
There was a problem hiding this comment.
mainnet? this dapp isn't intended for use on mainnet, is it?
There was a problem hiding this comment.
LuqiPan
force-pushed
the
977-mint-tickets-ui
branch
from
1599199
to
1150103
Compare
dckc
reviewed
Apr 2, 2024
package.json
Outdated
Comment on lines
47
to
48
| "start:ui": "cd ui && yarn dev", | ||
| "start:interchain-ui": "cd interchain-ui && yarn dev", |
There was a problem hiding this comment.
why keep start:ui?
Suggested change
| "start:ui": "cd ui && yarn dev", | |
| "start:interchain-ui": "cd interchain-ui && yarn dev", | |
| "start:ui": "cd interchain-ui && yarn dev", |
likewise the interchain-ui directory should replace /ui/, right?
dckc
reviewed
Apr 2, 2024
package.json
Outdated
| @@ -50,6 +51,7 @@ | |||
| "print-key": "yarn docker:make print-acct", | |||
There was a problem hiding this comment.
print-key is no more; likewise in contract/package.json
ci is griping about it:
https://github.com/Agoric/dapp-agoric-basics/actions/runs/8528223941/job/23361355100?pr=18#step:8:7
Closed
kbennett2000
approved these changes
Apr 22, 2024
kbennett2000
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Agoric/documentation#977