E2E tests for gov3 and gov4 wallets #142
Conversation
Deploying dapp-econ-gov with
|
| Latest commit: |
4027d6c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8ddc65c0.dapp-econ-gov.pages.dev |
| Branch Preview URL: | https://rs-test-this-branch.dapp-econ-gov.pages.dev |
|
Cloudflare deployment logs are available here |
rabi-siddique
force-pushed
the
rs-gov4-tests
branch
3 times, most recently
from
e1048d9
to
f3d47fe
Compare
rabi-siddique
force-pushed
the
rs-gov4-tests
branch
3 times, most recently
from
ebdffab
to
2d97a5c
Compare
rabi-siddique
force-pushed
the
rs-gov4-tests
branch
from
2d97a5c
to
b6962fa
Compare
|
Let's test that gov3's voting rights are revoked as well. |
rabi-siddique
force-pushed
the
rs-gov4-tests
branch
2 times, most recently
from
979a1ef
to
64a6e05
Compare
rabi-siddique
force-pushed
the
rs-gov4-tests
branch
from
64a6e05
to
bd56959
Compare
rabi-siddique
force-pushed
the
rs-gov4-tests
branch
2 times, most recently
from
e17b701
to
6f0b9da
Compare
rabi-siddique
changed the title
rabi-siddique
force-pushed
the
rs-gov4-tests
branch
3 times, most recently
from
477a948
to
9f7e6fb
Compare
.github/workflows/e2e_tests.yml
Outdated
| GOV1_PHRASE: ${{ inputs.gov1_mnemonic || secrets.GOV1_PHRASE }} | ||
| GOV2_PHRASE: ${{ inputs.gov2_mnemonic || secrets.GOV2_PHRASE }} |
There was a problem hiding this comment.
not directly related to this PR but we should remove these inputs for gov1 and gov2 and get the phrases from secrets only
| @@ -9,6 +9,9 @@ export const phrasesList = { | |||
| networkConfigURL: 'https://emerynet.agoric.net/network-config', | |||
| gov1Phrase: Cypress.env('GOV1_PHRASE'), | |||
| gov2Phrase: Cypress.env('GOV2_PHRASE'), | |||
| // UNTIL https://github.com/Agoric/dapp-econ-gov/issues/144 | |||
There was a problem hiding this comment.
what does this comment mean? i dont think that we will be removing these lines after this issue is resolved
There was a problem hiding this comment.
We won’t remove these lines. Instead, we’ll reverse the addresses. The "UNTIL" comment serves as a reminder and marker for where the update should occur.
There was a problem hiding this comment.
oh. missed that. thanks for clarifying
tests/e2e/specs/proposal.spec.js
Outdated
| @@ -54,7 +65,12 @@ describe('Make Proposal Tests', () => { | |||
| cy.acceptAccess(); | |||
| }); | |||
|
|
|||
| it('should allow gov1 to create a proposal', () => { | |||
| it('should allow gov2 to create a proposal', () => { | |||
| if (AGORIC_NET !== 'local') { | |||
There was a problem hiding this comment.
shouldnt this be done for all networks?
There was a problem hiding this comment.
I think so. Let me verify
There was a problem hiding this comment.
Yeah, you're right. Thanks for pointing it out.
Tested here in this testing branch:
https://github.com/Agoric/dapp-econ-gov/actions/runs/11574206948/job/32217963284?pr=145
rabi-siddique
force-pushed
the
rs-gov4-tests
branch
from
9f7e6fb
to
8f59c86
Compare
refs Agoric/agoric-sdk#10209
This PR introduces end-to-end(E2E) tests that use gov4 to propose questions and then vote on them using both gov4 and gov2 wallets. The objective is to verify whether gov4, as a new member of the EC committee, can effectively execute tasks related to the EC committee and charter.
The PR also adds E2E tests that ensure gov3 can no longer propose and vote on questions.